[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-api
Subject: Re: [PATCH v2] samsung-laptop: enable better lid handling
From: Julijonas Kikutis <julijonas.kikutis () gmail ! com>
Date: 2015-01-29 13:12:52
Message-ID: 1422537172.1835.4.camel () gmail ! com
[Download RAW message or body]
> Patch is generally fine, thanks for addressing my comments. Prior to merging I
> always run checkpatch.pl just in case I missed anything obvious:
>
> $ scripts/checkpatch.pl ~/samsung/01-lid-handling.patch
> WARNING: Prefer kstrto<type> to single variable sscanf
> #219: FILE: drivers/platform/x86/samsung-laptop.c:900:
> + if (!count || sscanf(buf, "%i", &value) != 1)
> + return -EINVAL;
>
> total: 0 errors, 1 warnings, 219 lines checked
>
> Please always run checkpatch.pl. It isn't sufficient and doesn't catch
> everything, but it is a minimum bar kind of thing.
I did run checkpatch.pl but left sscanf to be consistent with
set_battery_life_extender and set_usb_charge functions. Nevertheless, I
have just sent the third version of the patch with sscanf changed to
kstrtoint.
Thank you.
Julijonas
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic