[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-acpi
Subject: RE: [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing
From: "Moore, Robert" <robert.moore () intel ! com>
Date: 2015-03-30 17:09:02
Message-ID: 94F2FBAB4432B54E8AACC7DFDE6C92E37D2B1C7B () ORSMSX112 ! amr ! corp ! intel ! com
[Download RAW message or body]
AE_AML_OPERAND_TYPE -- used to indicate an exception raised by a type issue related to the AML code. Used to differentiate between a programmer error (AE_TYPE).
> -----Original Message-----
> From: Suravee Suthikulanit [mailto:suravee.suthikulpanit@amd.com]
> Sent: Monday, March 30, 2015 7:17 AM
> To: Moore, Robert; rjw@rjwysocki.net; mika.westerberg@linux.intel.com;
> Zheng, Lv; hanjun.guo@linaro.org
> Cc: lenb@kernel.org; hdegoede@redhat.com; tj@kernel.org;
> mjg59@srcf.ucam.org; gregkh@linuxfoundation.org; al.stone@linaro.org;
> graeme.gregory@linaro.org; leo.duran@amd.com; linux-ide@vger.kernel.org;
> linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linaro-
> acpi@lists.linaro.org
> Subject: Re: [V7 PATCH 1/3] ACPICA: Add ACPI _CLS processing
>
> On 3/27/2015 12:51 PM, Moore, Robert wrote:
> > + cls_objects = obj_desc->package.elements;
> > +
> > + if (obj_desc->common.type == ACPI_TYPE_PACKAGE &&
> > + obj_desc->package.count == 3 &&
> > + cls_objects[0]->common.type == ACPI_TYPE_INTEGER &&
> > + cls_objects[1]->common.type == ACPI_TYPE_INTEGER &&
> > + cls_objects[2]->common.type == ACPI_TYPE_INTEGER) {
> > +
> > + /* Allocate a buffer for the CLS */
> > + cls = ACPI_ALLOCATE_ZEROED(sizeof(struct acpi_pnp_device_id) +
> > + (acpi_size) 7);
> >
> > I would like to see an error returned if an object or subobject is of
> the incorrect type.
> > Then, the caller knows not to attempt to look at it.
> >
>
> Ok. I will return AE_TYPE if the condition is false here.
>
> Thanks,
>
> Suravee
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic