[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linaro-toolchain
Subject:    Re: Fwd: [Linaro-TCWG-CI] 2 patches in gdb: Failure
From:       Thiago Jung Bauermann <thiago.bauermann () linaro ! org>
Date:       2023-09-26 17:23:51
Message-ID: 87lecs7src.fsf () linaro ! org
[Download RAW message or body]


Guinevere Larsen <blarsen@redhat.com> writes:

> On 26/09/2023 18:04, Thiago Jung Bauermann wrote:
>> Hello Guinevere,
>>
>> Guinevere Larsen <blarsen@redhat.com> writes:
>>
>>> I got 3 of these messages about a patch I have upstream, which seems excessive.
>>> I also just managed to grab an aarch64 box and test it and got no errors, so I'd
>>> appreciate someone double checking that those werent 3 false positives please.
>> I'm sorry for the false positive and the extra messages (Could you
>> forward them (with full headers) to me, please? Perhaps we can prevent
>> sending identical messages in the case of an unexpected mishap).
> Yes of course! I'm not very knowledgeable in email, did you get all headers with this
> forward,

No, I only got Subject, Date, From, Reply-To and To.

> or is it better if I attach them to a private email to you?

Yes, normally there's a "forward message as attachment" option which
sends the complete email with all headers.

>> And thank you for testing on an aarch64 box that the patches are indeed
>> ok.
>>
>> What happened here is that the In-Reply-To: fields of the v2 messages
>> all point to the v1 patch. IIUC, normally the v2 cover letter would
>> point to the v1 patch, and patches 1 and 2 would point to the v2 cover
>> letter. This confused patchwork's series detection and so our CI applied
>> the v2 2/2 patch on top of the v1 patch instead of the v2 1/2 patch.
>> This of course caused a build failure.
>
> Yeah, I don't understand what happened with my git, but lucky that it did bring up the
> multiple replies thing at least.
>
> I wonder if that is related? Could the CI have looked at all emails, found the parent
> which is a real patch, and applied 2/2 for all emails, regardless of which email was being
> tested due to some patch series heuristic?

The patch series detection is done by Patchwork, and our CI just uses
its API to get the series and apply it. What I'm proposing is a
sanity check in our CI to detect whether Patchwork got the series right
or not.

I believe that what you are proposing would have to be implemented in
Patchwork itself. I'll look into whether we can make that improvement to
Patchwork.

-- 
Thiago
_______________________________________________
linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org
To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.org
[prev in list] [next in list] [prev in thread] [next in thread]