[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linaro-kernel
Subject:    Re: [PATCH] dma: imx-sdma: Remove spurious __init annotation on sdma_probe()
From:       Vinod Koul <vinod.koul () intel ! com>
Date:       2014-08-28 7:26:46
Message-ID: 20140828071446.GL13288 () intel ! com
[Download RAW message or body]

On Wed, Aug 27, 2014 at 11:55:53AM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> We can't annotate probe functions as __init since binding can occur at
> any time, not just during kernel init.

Applied, thanks

-- 
~Vinod

> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/dma/imx-sdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c615e88c118a..52ce1d21154c 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1448,7 +1448,7 @@ static struct dma_chan *sdma_xlate(struct of_phandle_args *dma_spec,
>  	return dma_request_channel(mask, sdma_filter_fn, &data);
>  }
>  
> -static int __init sdma_probe(struct platform_device *pdev)
> +static int sdma_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *of_id =
>  			of_match_device(sdma_dt_ids, &pdev->dev);
> -- 
> 2.1.0.rc1
> 

-- 

_______________________________________________
linaro-kernel mailing list
linaro-kernel@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-kernel
[prev in list] [next in list] [prev in thread] [next in thread]