[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linaro-dev
Subject:    [Linaro-validation] Patch for YAML test definitions
From:       michael.hudson () linaro ! org (Michael Hudson-Doyle)
Date:       2012-12-17 0:22:51
Message-ID: 87a9td34tg.fsf () canonical ! com
[Download RAW message or body]

Fathi Boudra <fathi.boudra at linaro.org> writes:

> Hi,
>
> On 13 December 2012 11:48, Senthil Kumaran <senthil.kumaran at linaro.org> wrote:
>> Hi,
>>
>> I converted lava-test test definitions to work on lava-test-shell with the
>> new YAML format. These converted tests are mostly from
>> https://code.launchpad.net/~linaro-foundations
>>
>> I request someone from developer platform team to merge these tests to the
>> bzr repositories so that it will be easy to maintain these tests in future.
>
> Commited. Thanks Senthil.

I'm a little confused, for a few reasons:

0) Why were these merges not requested as merge proposals on Launchpad?

1) Fathi says "committed" but
   e.g. lp:~linaro-foundations/linaro-ubuntu/lava-test-device-tree does
   not seem to have had device-tree-patch.txt applied.

2) The patches themselves are a little strange: device-tree-patch.txt,
   when applied to
   lp:~linaro-foundations/linaro-ubuntu/lava-test-device-tree means that
   one can use a lava_test_shell action that has {'bzr-repo':
   'lp:~linaro-foundations/linaro-ubuntu/lava-test-device-tree'} but you
   also need to set testdef to 'yaml/device-tree.yaml' rather than just
   adding it as the default lavatest.yaml and *then* even if you did
   this, the testdef would check
   lp:~linaro-foundations/linaro-ubuntu/lava-test-device-tree out again
   and run the tests from this second copy.

Am I horribly misunderstanding something here?  Even if I am, I still
think things should be redone like I outline above!

Cheers,
mwh


[prev in list] [next in list] [prev in thread] [next in thread]