[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lilypond-devel
Subject:    Re: Auto_change_iterator: move some state from C++ to Scheme (issue 248470043 by nine.fierce.ballads
From:       nine.fierce.ballads () gmail ! com
Date:       2015-06-29 12:23:36
Message-ID: 047d7b112103ad01670519a72899 () google ! com
[Download RAW message or body]


https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm
File scm/autochange.scm (right):

https://codereview.appspot.com/248470043/diff/1/scm/autochange.scm#newcode38
scm/autochange.scm:38: (m1 (make-non-relative-music (context-spec-music
music 'Voice "one")))
On 2015/06/29 09:03:56, thomasmorley651 wrote:
> If I'm not mistaken the local variable 'm1' isn't used. Delete his
line!?

Another possibility is that it was intended to be used, but by mistake
it wasn't, so that there are undiscovered bugs.

I'll try to consider this later today, but I'm not promising to change
anything.

Thanks for your review.

https://codereview.appspot.com/248470043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
[prev in list] [next in list] [prev in thread] [next in thread]