[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lilypond-devel
Subject:    Issue 3190: Fix W3C compliance. (issue 10774043)
From:       markpolesky () gmail ! com
Date:       2013-06-29 2:48:53
Message-ID: 047d7bdc9e6c2c71ba04e04209f9 () google ! com
[Download RAW message or body]

Reviewers: ,

Message:
Issue 3190 lists 2 separate problems, w3c compliance and lynx
compatibility:
http://code.google.com/p/lilypond/issues/detail?id=3190

I've fixed the w3c compliance problem, though I haven't checked the lynx
problem.  If the lynx thing is still problematic, someone should open a
new issue for that.

Adding extra @multitable's was the way to go; the misaligned columns
were easily solved by explicitly giving widths to the tables in css.  In
the future, if a new manual link ever gets added with a name too long to
fit, it is trivial to adjust the css rule.

There was another option of using:
@multitable {dummy text to space col 1} {same for col 2}, etc.

...but I chose to take the css route.

One last thing, another patch I posted early today edits the same file,
Documentation/css/lilypond-website.css
(https://codereview.appspot.com/10700044/).  I don't know if a rebase
will be needed or what, just thought I'd mention it.

Feel free to check this.

Thanks.
- Mark

Description:
Issue 3190: Fix W3C compliance.

Fix incorrect nesting of tables in `Manuals' section of
   Community > Development on website.

Adjust css rules as needed.

Please review this at https://codereview.appspot.com/10774043/

Affected files:
   M Documentation/css/lilypond-website.css
   M Documentation/web/community.itexi


Index: Documentation/css/lilypond-website.css
diff --git a/Documentation/css/lilypond-website.css  
b/Documentation/css/lilypond-website.css
index  
9daf395dc6e6d978979b851dab0cbc001c23376c..8589befe429d6ae012259ec444e1a71bf8d18422  
100644
--- a/Documentation/css/lilypond-website.css
+++ b/Documentation/css/lilypond-website.css
@@ -903,6 +903,7 @@ div.color4 h3 {
    padding : 0em;
    border-left: 2px;
    margin: 0em;
+  width: 67%;
  }

  .normal-table table td {
Index: Documentation/web/community.itexi
diff --git a/Documentation/web/community.itexi  
b/Documentation/web/community.itexi
index  
b87062c7ba7c5edf0eeeab40e10fbfcec285da86..54723d77f59f016826fa53d0647ae03b28d5466a  
100644
--- a/Documentation/web/community.itexi
+++ b/Documentation/web/community.itexi
@@ -785,6 +785,7 @@ manuals can be found at @url{http://lilypond.org}}
  @divClass{normal-table}
  @multitable @columnfractions .3 .3 .3
  @headitem Introduction
+
  @item
  @docLinkSplit{Learning,learning,@manualDevelLearningSplit}
  @tab
@@ -805,7 +806,9 @@ manuals can be found at @url{http://lilypond.org}}
  @docLinkBig{Essay,essay,@manualDevelEssayBig}
  @tab
  @docLinkPdf{Essay,essay,@manualDevelEssayPdf}
+@end multitable

+@multitable @columnfractions .3 .3 .3
  @headitem Regular

  @item
@@ -828,7 +831,9 @@ manuals can be found at @url{http://lilypond.org}}
  @docLinkBig{Snippets,snippets,@manualDevelSnippetsBig}
  @tab
  @docLinkPdf{Snippets,snippets,@manualDevelSnippetsPdf}
+@end multitable

+@multitable @columnfractions .3 .3 .3
  @headitem Infrequent

  @item
@@ -858,15 +863,17 @@ manuals can be found at @url{http://lilypond.org}}
  @docLinkBig{Internals,internals,@manualDevelInternalsBig}
  @tab
  @docLinkPdf{Internals,internals,@manualDevelInternalsPdf}
+@end multitable

  @ifset web_version
+@multitable @columnfractions .3
  @headitem Downloadable

  @item
  @doctarballDevel
+@end multitable
  @end ifset

-@end multitable

  @divEnd
  @divEnd




[prev in list] [next in list] [prev in thread] [next in thread]