[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lilypond-devel
Subject:    Re: PATCH: Eliminate PDF deletion in Windows
From:       Carl Sorensen <c_sorensen () byu ! edu>
Date:       2010-04-30 3:32:36
Message-ID: C7FF9D30.11F75%c_sorensen () byu ! edu
[Download RAW message or body]

On 4/27/10 10:49 PM, "Nathan Reed" <nathaniel.reed@gmail.com> wrote:

> Lilypond would attempt to delete the output PDF before overwriting it in
> Windows
> (but no other platforms).  This is unnecessary and causes problems with
> certain
> PDF viewers, e.g. Sumatra, where the PDF is kept open in a way that allow=
s
> overwriting but not deletion.  See also the discussion on bug-lilypond[1]=
.

I've reviewed this patch, and it looks good to me.  I don't run LilyPond on
Windows.  Nathan has tested with multiple PDF viewers, and it seems to be
better on some and no worse on any of them that have been tested.

Are there any objections to having me push this patch?

Thanks,

Carl




[prev in list] [next in list] [prev in thread] [next in thread]