[prev in list] [next in list] [prev in thread] [next in thread] 

List:       lilypond-devel
Subject:    Re: deleting files in input/test
From:       Jan Nieuwenhuizen <janneke () gnu ! org>
Date:       2003-06-11 11:42:29
Message-ID: 87fzmg3knu.fsf () peder ! flower
[Download RAW message or body]

Graham Percival <gperlist@shaw.ca> writes:

> OK, I think I see the point now.  We'll keep it, although I'll probably
> change the filename (if only to write out "autochange-extra-voice.ly")

That's better in any case.

> But I'd just to make sure I'm doing the right thing: as far as I
> understand, input/test is supposed to be examples to demonstrate tricky
> things you can do with Lilypond.  input/regression is supposed to be for
> code snippets which "test" new version of Lilypond to make sure they do
> everything they're supposed to.

Yes.  That's how it is supposed to be.

> While I'm looking at an input/test file, currently I only look at
> whether that file demonstrates something useful for an end-user.  I
> don't try to judge whether the file is useful in regression testing; in
> part because I thought that was what input/regression was for, but
> mainly because I don't know enough about Lilypond internals (or
> engraving, for that matter -- I didn't know that the beams needed to be
> horizontal) to judge whether or not it's a useful regression test.

That's part of the problem: regtest snippets should be short, test
just one feature, and describe what the test is about; what you should
see.

> (sometimes I'll mark a file as "delete or move to regression"; I don't
> _totally_ ignore the usefulness of a code snippet in regression testing)
> 
> Is this what I should be doing?  I'll never delete a file without asking
> if it's ok on the mailist, so if a file is needed for regression, somebody
> can tell me and it'll get moved instead of deleted.

Yes, I'm quite happy that you help sorting out the cruft.

> > > > beam-pos.ly
> 
> When you say "keep it", do you mean "keep it in input/test", or "move
> it to input/regression and keep it there"?
> (or even "move it to input/bugs and keep it there")

Sorry.  Move to regtest in this case.  This file does not show a trick.

> > > > beam-second.ly
> 
> Should we move it to regression?

Yes.

Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org




[prev in list] [next in list] [prev in thread] [next in thread]