[prev in list] [next in list] [prev in thread] [next in thread] 

List:       licq-devel
Subject:    [Licq-devel] [PATCH] missing codec->fromUnicode()
From:       glee () gnupilgrims ! org
Date:       2003-01-26 16:19:50
[Download RAW message or body]

Hi all,


Here is a patch which adds missing codec->fromUnicode().  (Untested, but
should work)

Also, some questions:

(1) does an event e->ExtendedAck()->Response() need translation to unicode?
    What encoding does this method return? 

(2) I've experienced an odd behavior when a remote client refuses a file
    transfer with a reason, licq will initiate the transfer only to fail
    with a bind() error (well, we all know why that happens, because
    the transfer was refused).  this may indicate some mis-interaction
    with the protocol or the licq daemon (someone wishes to investigate?)

(3) I have Chinese characters in my information, every time i update it
    and close the info window, and re-open it, all of it turns into a
    square (unrecognizable character).  After I retrieve things from the 
    server all's well again.  I have checked the fromUnicode() and
    toUnicode() conversion and it seems to be well ... (someone wishes
    to double-check, perhaps?  I think I am wrong)

(4) When I start my client users which have Chinese characters on my
    list turn into question marks.  After updating from the server all's
    well again (similar to the previous problem, maybe?)


Anyway, I would be happy to help debug the above problems.


	-- G.



["licq-fromUnicode.patch" (text/plain)]

diff -ur licq-20021222.orig/plugins/qt-gui/src/usereventdlg.cpp \
                licq-20021222/plugins/qt-gui/src/usereventdlg.cpp
--- licq-20021222.orig/plugins/qt-gui/src/usereventdlg.cpp	Tue Dec 10 14:45:10 2002
+++ licq-20021222/plugins/qt-gui/src/usereventdlg.cpp	Sun Jan 26 23:50:55 2003
@@ -1807,7 +1807,7 @@
   if (!e->ExtendedAck()->Accepted())
   {
     ICQUser *u = gUserManager.FetchUser(m_nUin, LOCK_R);
-    QString result = tr("File transfer with %2 \
refused:\n%3").arg(u->GetAlias()).arg(e->ExtendedAck()->Response()); +    QString \
result = tr("File transfer with %2 \
refused:\n%3").arg(codec->fromUnicode(u->GetAlias())).arg(e->ExtendedAck()->Response());
  gUserManager.DropUser(u);
     InformUser(this, result);
   }
@@ -1923,7 +1923,7 @@
   if (!e->ExtendedAck()->Accepted())
   {
     ICQUser *u = gUserManager.FetchUser(m_nUin, LOCK_R);
-    QString result = tr("Chat with %2 refused:\n%3").arg(u->GetAlias())
+    QString result = tr("Chat with %2 \
                refused:\n%3").arg(codec->fromUnicode(u->GetAlias()))
                      .arg(e->ExtendedAck()->Response());
     gUserManager.DropUser(u);
     InformUser(this, result);
 


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Licq-devel mailing list
Licq-devel@licq.org
https://lists.sourceforge.net/lists/listinfo/licq-devel

[prev in list] [next in list] [prev in thread] [next in thread]