[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [PATCH V3] support for hotplug/hotunplug in test hypervisor
From:       John Levon <levon () movementarian ! org>
Date:       2023-10-31 10:12:51
Message-ID: ZUDTIwu9K+qoaGDK () movementarian ! org
[Download RAW message or body]

On Tue, Oct 31, 2023 at 10:49:31AM +0100, Michal Prívozník wrote:

> > +    VIR_APPEND_ELEMENT(vm->def->hostdevs, vm->def->nhostdevs,
> 
> But anyway, I think we want more elaborate approach. The whole point of
> the test driver is to mimic real guest(s) without resources needed. IOW,

Michal, point taken, but are you saying you wouldn't take such a change unless
it implemented attach for all possible devices?

Or would you be OK with a partial implementation that handles hostdev, but
returns the equivalent of ENOTSUP for everything else?

Reason I ask is that right now we only have a need for hostdev testing.

regards
john
[prev in list] [next in list] [prev in thread] [next in thread]