[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo
From:       Markus Armbruster <armbru () redhat ! com>
Date:       2023-04-25 13:08:28
Message-ID: 875y9kun1v.fsf () pond ! sub ! org
[Download RAW message or body]

Peter Maydell <peter.maydell@linaro.org> writes:

> On Tue, 25 Apr 2023 at 13:10, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>> > -# Notes: @singlestep is enabled through the GDB stub
>> > +# Notes: @singlestep is enabled on the command line with
>> > +#        '-accel tcg,one-insn-per-tb=on', or with the HMP
>> > +#        'one-insn-per-tb' command.
>>
>> You're deleting "enabled through the GDB stub".  Is this one of the
>> misstatements you alluded to in the commit message
>
> Yes -- this field has never been anything to do with
> GDB-enabled singlestep (or for that matter with
> emulation of any guest-CPU architecture singlestep
> functionality). I assume that whoever originally wrote
> that text was confused by the terrible name of the
> command line option/global variable.

Thanks!

Reviewed-by: Markus Armbruster <armbru@redhat.com>

[prev in list] [next in list] [prev in thread] [next in thread]