[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt PATCH 1/5] nwfilter: stop using recursive mutex for IP learning
From:       Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange () redhat ! com>
Date:       2022-02-28 16:15:15
Message-ID: Yhz1E6jFftHwso6B () redhat ! com
[Download RAW message or body]

On Mon, Feb 28, 2022 at 11:05:09AM -0500, Laine Stump wrote:
> On 2/25/22 10:30 AM, Daniel P. Berrangé wrote:
> > The virNWFilterLockIface method is only called from one place,
> > the learnIPAddressThread method.
> 
> nwfilter_gentech_driver.c:virNWFilterDoInstantiate() and
> _virNWFilterTeardownFilter() also call virNWFilterLockIface.

Sigh, yes.

I didn't properly consider that stuff outside of
learnip.c would be using its mutex. We should move
the iface locking into the gentech driver to make
it clear is is shared functionality.

Consider this patch dropped.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

[prev in list] [next in list] [prev in thread] [next in thread]