[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    [PATCH 1/4] test_driver: Don't leak @group_name
From:       Michal Privoznik <mprivozn () redhat ! com>
Date:       2022-01-31 14:53:39
Message-ID: 24f31f7b178c00470f802fb2553c3d83859df0f1.1643640752.git.mprivozn () redhat ! com
[Download RAW message or body]

In testDomainSetBlockIoTune() the info.group_name is strdup()-ed
and just after the whole @info structure is passed to
virDomainDiskSetBlockIOTune() the @group_name member is set to
NULL. This creates a memleak, because
virDomainDiskSetBlockIOTune() creates its own copy of the string.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/test/test_driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 1504334c30..9e1fc65972 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -4027,7 +4027,6 @@ testDomainSetBlockIoTune(virDomainPtr dom,
 #undef TEST_BLOCK_IOTUNE_MAX_CHECK
 
     virDomainDiskSetBlockIOTune(conf_disk, &info);
-    info.group_name = NULL;
 
     ret = 0;
  cleanup:
-- 
2.34.1

[prev in list] [next in list] [prev in thread] [next in thread]