[prev in list] [next in list] [prev in thread] [next in thread]
List: libvir-list
Subject: Re: [PATCH] qemu: Replace deprecated short-form boolean options
From: Han Han <hhan () redhat ! com>
Date: 2021-01-29 22:11:55
Message-ID: CAHjf+S-wSC0JJh+8YQ7uAgbJQWQQv-Vk+MKQxEKdELwvB7pacA () mail ! gmail ! com
[Download RAW message or body]
On Tue, Jan 26, 2021 at 6:04 PM Peter Krempa <pkrempa@redhat.com> wrote:
> On Tue, Jan 26, 2021 at 11:55:25 +0800, Han Han wrote:
> > Since the commit ccd3b3b811 of QEMU, the short-form boolean options in
> > qemu cmdline like "server", "nowait", "disable-ticketing" are deprecated:
> >
> > qemu-system-x86_64: -chardev socket,id=charmonitor,fd=38,server,nowait:
> warning: short-form boolean option 'server' deprecated
> > Please use server=on instead
> > qemu-system-x86_64: -chardev socket,id=charmonitor,fd=38,server,nowait:
> warning: short-form boolean option 'nowait' deprecated
> > Please use wait=off instead
> > qemu-system-x86_64: -spice
> port=5900,addr=127.0.0.1,disable-ticketing,plaintext-channel=main,plaintext-channel= \
> inputs,image-compression=auto_glz,jpeg-wan-compression=auto,zlib-glz-wan-compression \
> =auto,playback-compression=on,streaming-video=filter,disable-copy-paste,disable-agent-file-xfer,seamless-migration=on:
>
> warning: short-form boolean option 'disable-ticketing' deprecated
> > Please use disable-ticketing=on instead
> >
> > Use normal form boolean options with value "on" or "off".
> >
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
>
> [...]
>
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-default-both.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-default-v2.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-default-v3.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-default.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-none-both.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-none-v2.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-none-v3.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/aarch64-gic-none.args
> > mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-full.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/cpu-check-partial.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-2.12.0.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-latest.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/mach-virt-console-native.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/mach-virt-serial+console-native.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/mach-virt-serial-compat.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/pci-rom-disabled-invalid.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/pseries-console-native.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/pseries-serial+console-native.args
> > mode change 120000 => 100644
> tests/qemuxml2argvdata/pseries-serial-compat.args
> > mode change 120000 => 100644 tests/qemuxml2argvdata/user-aliases2.args
>
> These files are expanded from a symlink to a full file. Did you use a
> script/sed to do the changes? Preferably unless necessary don't expand
>
yes
> those and use VIR_TEST_REGENERATE_OUTPUT=1 to generate them, that
> doesn't expand symlinks.
>
> Thank you. I'll fix that in the next version
[Attachment #3 (text/html)]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Tue, Jan 26, 2021 at 6:04 PM Peter Krempa <<a \
href="mailto:pkrempa@redhat.com">pkrempa@redhat.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jan 26, 2021 \
at 11:55:25 +0800, Han Han wrote:<br> > Since the commit ccd3b3b811 of QEMU, the \
short-form boolean options in<br> > qemu cmdline like "server", \
"nowait", "disable-ticketing" are deprecated:<br> > <br>
> qemu-system-x86_64: -chardev socket,id=charmonitor,fd=38,server,nowait: warning: \
short-form boolean option 'server' deprecated<br> > Please use server=on \
instead<br> > qemu-system-x86_64: -chardev \
socket,id=charmonitor,fd=38,server,nowait: warning: short-form boolean option \
'nowait' deprecated<br> > Please use wait=off instead<br>
> qemu-system-x86_64: -spice \
port=5900,addr=127.0.0.1,disable-ticketing,plaintext-channel=main,plaintext-channel=in \
puts,image-compression=auto_glz,jpeg-wan-compression=auto,zlib-glz-wan-compression=aut \
o,playback-compression=on,streaming-video=filter,disable-copy-paste,disable-agent-file-xfer,seamless-migration=on: \
warning: short-form boolean option 'disable-ticketing' deprecated<br> > \
Please use disable-ticketing=on instead<br> > <br>
> Use normal form boolean options with value "on" or \
"off".<br> > <br>
> Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" \
target="_blank">hhan@redhat.com</a>><br> > ---<br>
<br>
[...]<br>
<br>
> mode change 120000 => 100644 \
tests/qemuxml2argvdata/aarch64-gic-default-both.args<br> > mode change 120000 \
=> 100644 tests/qemuxml2argvdata/aarch64-gic-default-v2.args<br> > mode \
change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-default-v3.args<br> \
> mode change 120000 => 100644 \
tests/qemuxml2argvdata/aarch64-gic-default.args<br> > mode change 120000 => \
100644 tests/qemuxml2argvdata/aarch64-gic-none-both.args<br> > mode change \
120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v2.args<br> > mode \
change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none-v3.args<br> > \
mode change 120000 => 100644 tests/qemuxml2argvdata/aarch64-gic-none.args<br> > \
mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-full.args<br> > \
mode change 120000 => 100644 tests/qemuxml2argvdata/cpu-check-partial.args<br> \
> mode change 120000 => 100644 \
tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-2.12.0.args<br> > mode \
change 120000 => 100644 \
tests/qemuxml2argvdata/disk-backing-chains-index.x86_64-latest.args<br> > mode \
change 120000 => 100644 tests/qemuxml2argvdata/mach-virt-console-native.args<br> \
> mode change 120000 => 100644 \
tests/qemuxml2argvdata/mach-virt-serial+console-native.args<br> > mode change \
120000 => 100644 tests/qemuxml2argvdata/mach-virt-serial-compat.args<br> > \
mode change 120000 => 100644 \
tests/qemuxml2argvdata/pci-rom-disabled-invalid.args<br> > mode change 120000 \
=> 100644 tests/qemuxml2argvdata/pseries-console-native.args<br> > mode \
change 120000 => 100644 \
tests/qemuxml2argvdata/pseries-serial+console-native.args<br> > mode change \
120000 => 100644 tests/qemuxml2argvdata/pseries-serial-compat.args<br> > mode \
change 120000 => 100644 tests/qemuxml2argvdata/user-aliases2.args<br> <br>
These files are expanded from a symlink to a full file. Did you use a<br>
script/sed to do the changes? Preferably unless necessary don't \
expand<br></blockquote><div>yes <br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> those and use VIR_TEST_REGENERATE_OUTPUT=1 to \
generate them, that<br> doesn't expand symlinks.<br>
<br></blockquote><div>Thank you. I'll fix that in the next version \
<br></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic