[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt PATCH v2 54/56] src: ensure use of g_printf / g_fprintf functions
From:       Pavel Hrdina <phrdina () redhat ! com>
Date:       2020-01-31 16:22:38
Message-ID: 20200131162238.GB1733890 () antique-laptop
[Download RAW message or body]


On Tue, Jan 28, 2020 at 01:11:35PM +0000, Daniel P. Berrangé wrote:
> The printf/fprintf function impls provided on Windows do
> not follow the normal syntax for format specifiers as
> the UNIX hosts. Currently we use GNULIB to provide a
> portability fix for this. GLib has also imported the
> GNULIB impl for this same reason, and thus we can rely
> on the g_printf / g_fprintf functions.
> 
> This identified a couple of places not explicitly
> linking to glib.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  src/internal.h              | 14 ++++++++++++++
>  src/locking/Makefile.inc.am |  5 ++++-
>  2 files changed, 18 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]