[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] qemu: Fix migration without parameters
From:       Erik Skultety <eskultet () redhat ! com>
Date:       2019-11-28 12:57:02
Message-ID: 20191128125702.GC741383 () ridgehead ! usersys ! redhat ! com
[Download RAW message or body]

On Thu, Nov 28, 2019 at 11:24:04AM +0100, Jiri Denemark wrote:
> The virTypedParamsFilter function doesn't mind params == NULL if nparams
> is zero. And there's no need to check for params == NULL && nparams > 0
> because this is checked higher in the stack.
>
> In fact all the virCheckNonNull* checks in virTypedParamsFilter are
> useless.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1777094
>
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[prev in list] [next in list] [prev in thread] [next in thread]