[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [jenkins-ci PATCH 2/6] mingw*-libosinfo: Add mingw*-libsoup as dependency
From:       Fabiano_Fidêncio <fidencio () redhat ! com>
Date:       2019-07-31 12:39:04
Message-ID: CAAY6Xsf7gtrFNY0xeCsoxYOAajvu4VoJPWs+G9cc5GWxms+Lzw () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jul 31, 2019 at 2:37 PM Andrea Bolognani <abologna@redhat.com> wrote:
>
> On Wed, 2019-07-31 at 14:24 +0200, Fabiano Fidêncio wrote:
> > On Wed, Jul 31, 2019 at 1:54 PM Andrea Bolognani <abologna@redhat.com> wrote:
> > > On Mon, 2019-07-29 at 10:41 +0200, Fabiano Fidêncio wrote:
> > > > It's been introduced as dependency as part of v1.6.0 release.
> > >
> > > Is that so? Because the native build has had the dependency on
> > > libsoup ever since
> > >
> > >   commit 1eab5a66eb0abd922a67e2c96a4c46efce525548
> > >   Author: Andrea Bolognani <abologna@redhat.com>
> > >   Date:   Tue Oct 3 18:11:38 2017 +0200
> > >
> > >     ansible: Add libosinfo project
> > >
> > >     Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> > >
> > > eg. the day it was introduced. So it seems to me we just messed
> > > up when in
> >
> > Old tests on libosinfo were relying on libsoup and that's the reason I
> > do believe the dependency was there.
> > Pino dropped the dependency a long time ago here:
> >
> > ```
> > commit b61be0405f678986ac344f414fa907af24670488
> > Author:     Pino Toscano <ptoscano@redhat.com>
> > AuthorDate: Mon Aug 7 18:18:34 2017 +0200
> > Commit:     Christophe Fergeau <cfergeau@redhat.com>
> > CommitDate: Mon Oct 16 11:12:22 2017 +0200
> >
> >     Switch from libsoup to libcurl
> >
> >     libsoup is used to check the validity of URLs in distributions in
> >     osinfo-db; OTOH it supports only HTTP(S), so this limits the checks to
> >     that protocol.
> >
> >     To overcome this limitation, switch to libcurl: while it requires
> >     slightly more code to do the same task, it provides a bit more
> >     flexibility, and support for other protocols.  No version check is
> >     performed, since the APIs used are old enough.
> >
> >     Adapt also the README, and the packaging files.
> > ```
> > However, libvirt-jenkins-ci was never updated.
>
> Alright, I'll keep your commit message as is but I'll add
>
>   The native build already depended on libsoup because it was never
>   updated after libosinfo switched its test suite from libsoup to
>   libcurl back in 2017.
>
> and then push the series.

Ack!

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[prev in list] [next in list] [prev in thread] [next in thread]