[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH v2 1/2] qemu: Fix "boolen" typo in API doc
From:       Christophe Fergeau <cfergeau () redhat ! com>
Date:       2019-03-29 14:05:17
Message-ID: 20190329140517.GA7710 () natto ! ory ! fergeau ! eu
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hey,

On Wed, Mar 27, 2019 at 01:32:44PM +0100, Ján Tomko wrote:
> Please use --cover-letter for series with two or more patches for neater
> alignment of e-mails.
> 
> On Wed, Mar 27, 2019 at 12:21:24PM +0100, Christophe Fergeau wrote:
> > This also adjusts the argument name which should be 'isListen' in both
> > cases rather than 'listen'.
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
> > ---
> > Changes since v1:
> > - really fix 'boolen' typo
> > 
> > src/qemu/qemu_command.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> > index f81d20e5f7..82675c5d4e 100644
> > --- a/src/qemu/qemu_command.c
> > +++ b/src/qemu/qemu_command.c
> > @@ -876,7 +876,7 @@ qemuBuildRBDSecinfoURI(virBufferPtr buf,
> > 
> > /* qemuBuildTLSx509BackendProps:
> >  * @tlspath: path to the TLS credentials
> > - * @listen: boolen listen for client or server setting
> > + * @isListen: boolean listen for client or server setting
> 
> Both the rename and the typo fix could be qualified as trivial.
> However the description does not make much sense to me.

To me neither. Maybe this?
* @isListen: boolean indicating if this is a client or server TLS credentials

> 
> >  * @verifypeer: boolean to enable peer verification (form of authorization)
> 
> peer verification is also used for authentication, as of
> commit 441d3eb6d1be940a67ce45a286602a967601b157 (tag: CVE-2017-1000256)

Just need to append /authentication to the end?
* @verifypeer: boolean to enable peer verification (form of authorization/authentication)


Christophe

["signature.asc" (application/pgp-signature)]

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

[prev in list] [next in list] [prev in thread] [next in thread]