[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
From:       Maciej Wolny <maciej.wolny () codethink ! co ! uk>
Date:       2018-04-30 17:46:27
Message-ID: 65fc2b94-e5f5-7f8f-8d29-df74dcdeaa5d () codethink ! co ! uk
[Download RAW message or body]

On 30/04/18 18:11, Andrea Bolognani wrote:
>> -	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
>> +	$(MAKE) check VG="$(LIBTOOL) --mode=execute $(VALGRIND)"
> What we might want to do here is call $(top_srcdir)/libtool
> instead of plain libtool, so that we run the local copy installed
> by libtoolize rather than the vendor-provided one, and we don't
> require the user to install libtool at all when building from a
> release archive rather than a git checkout.

$(LIBTOOL) is set to $(top_srcdir)/libtool in the generated Makefile. My 
understanding was that automake copies the rule I modified verbatim into 
the generated Makefile, but maybe I misunderstood. If so, I'll post 
another patch as you suggested.

Here's the error message:
/bin/bash: line 2: libtool: command not found

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[prev in list] [next in list] [prev in thread] [next in thread]