[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH v3 3/5] qemu: Use VIR_ERR_DEVICE_MISSING for various hotplug messages
From:       John Ferlan <jferlan () redhat ! com>
Date:       2018-01-31 15:33:35
Message-ID: 7518e047-b1c0-5059-fb37-26598c8e10c7 () redhat ! com
[Download RAW message or body]



On 01/22/2018 11:24 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao@gmail.com>
> 
> Modify OPERATION_FAILED error codes to use DEVICE_MISSING instead.

I'll modify this one to:

Modify OPERATION_FAILED and INTERNAL_ERROR error codes to use
DEVICE_MISSING instead for failures associated with the inability to
find the device. This makes it easier for consumers to key off the error
code rather than the error message.

No need to post another series - just let me know if you're fine with
the adjusted text...

> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
> ---
> v3:
>   modify virDomainNetFindIdx to use VIR_ERR_DEVICE_MISSING
> 
>  src/conf/domain_conf.c  |  8 ++++----
>  src/qemu/qemu_hotplug.c | 24 ++++++++++++------------
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

[prev in list] [next in list] [prev in thread] [next in thread]