[prev in list] [next in list] [prev in thread] [next in thread]
List: libvir-list
Subject: Re: [libvirt] [PATCH] qemu-capabilities: Adjust function header comments of virQEMUCapsInitCPUModel*
From: Jiri Denemark <jdenemar () redhat ! com>
Date: 2017-11-29 16:46:16
Message-ID: 20171129164616.GB990718 () orkuz ! home
[Download RAW message or body]
On Mon, Nov 27, 2017 at 13:12:17 +0100, Boris Fiuczynski wrote:
> Adjust function descriptions of virQEMUCapsInitCPUModelS390 and
> virQEMUCapsInitCPUModel to the changes introduced with
> commitID 74fc32a955.
>
> Signed-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>
> Reviewed-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
> ---
> src/qemu/qemu_capabilities.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index f2d24a3..e4e25da 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -3308,8 +3308,7 @@ virQEMUCapsCPUFilterFeatures(const char *name,
> /**
> * Returns 0 when host CPU model provided by QEMU was filled in qemuCaps,
> * 1 when the caller should fall back to using virCapsPtr->host.cpu,
> - * 2 when cpu model info is not supported for this configuration and
> - * fall back should not be used.
> + * 2 when cpu model info is not supported for this configuration,
> * -1 on error.
> */
> static int
> @@ -3436,9 +3435,8 @@ virQEMUCapsInitCPUModelX86(virQEMUCapsPtr qemuCaps,
>
> /**
> * Returns 0 when host CPU model provided by QEMU was filled in qemuCaps,
> - * 1 when the caller should fall back to other methods
> - * 2 when cpu model info is not supported for this configuration and
> - * fall back should not be used.
> + * 1 when the caller should fall back to other methods,
> + * 2 when cpu model info is not supported for this configuration,
> * -1 on error.
> */
> int
ACK and pushed, thanks.
Jirka
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic