[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    [libvirt] [PATCH v2 0/4] Fix VolOpen error reporting
From:       Cole Robinson <crobinso () redhat ! com>
Date:       2014-03-31 18:50:44
Message-ID: cover.1396291652.git.crobinso () redhat ! com
[Download RAW message or body]

In https://bugzilla.redhat.com/show_bug.cgi?id=1080613 , something is
causing StorageVolGetXML to fail, but it's not raising any error message.
Code inspection found that most users of VolOpen are susceptible to error
reporting issues.

The first 3 patches are some code reorganization and cleanups that make
it easier to identify the VolOpen callers. Patch 4 fixes up the reporting
issue.

v2:
    Jan's suggestion to only report an error if caller passed in VOL_OPEN_ERROR

Cole Robinson (4):
  storage: Rename UpdateVolInfoFlags to UpdateVolInfo
  storage: move block format lookup to shared UpdateVolInfo
  storage: Rename VolOpenCheckMode to VolOpen
  storage: Report error from VolOpen if proper flag is passed

 src/storage/storage_backend.c         | 260 ++++++++++++++++++----------------
 src/storage/storage_backend.h         |  18 +--
 src/storage/storage_backend_disk.c    |   3 +-
 src/storage/storage_backend_fs.c      |  25 ++--
 src/storage/storage_backend_logical.c |  11 +-
 src/storage/storage_backend_mpath.c   |  36 +----
 src/storage/storage_backend_scsi.c    |  43 +-----
 7 files changed, 175 insertions(+), 221 deletions(-)

-- 
1.8.5.3

[prev in list] [next in list] [prev in thread] [next in thread]