[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] bhyve: don't leak tap devices on failures
From:       Roman Bogorodskiy <bogorodskiy () gmail ! com>
Date:       2014-03-31 13:09:07
Message-ID: 20140331130905.GA1275 () kloomba
[Download RAW message or body]


  Michal Privoznik wrote:

> On 30.03.2014 14:53, Roman Bogorodskiy wrote:
> > On failures, virBhyveProcessStart() does not cleanup network
> > interfaces that could be created by virBhyveProcessBuildBhyveCmd(),
> > which results in a leaked tap device.
> >
> > To fix that, extract network cleanup code to bhyveNetCleanup()
> > and use it in cleanup stage of virBhyveProcessStart().
> > ---
> >   src/bhyve/bhyve_process.c | 34 ++++++++++++++++++++++------------
> >   1 file changed, 22 insertions(+), 12 deletions(-)
>=20
> ACK and worth pushing prior to the release.

Pushed, thanks!

Roman Bogorodskiy

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]