[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH v5 2/2] Add de-association handling to macvlan code
From:       Laine Stump <laine () laine ! org>
Date:       2012-02-29 16:36:33
Message-ID: 4F4E5411.7070205 () laine ! org
[Download RAW message or body]

On 02/24/2012 09:29 AM, D. Herrendoerfer wrote:
> The callback mechanism is not re-armed when libvirt is restarted now.
> The reason is: lldpad remembers who sent the associate by pid - since
> in theory there could be multiple agents performing associations.
> So if the libvirt pid changes, there is little we can do now.

This seems very problematic to me - it is assumed that libvirt can be
restarted at any time with no ill effects, and restarting libvirt is
often suggested as a solution to clearing up problems (e.g. if some
other program stomps on libvirt's iptables rules).

What can be done to eliminate this problem? Perhaps there needs to be a
"re-associate" message - it could be sent each time libvirt restarts for
each association it's currently tracking.

[prev in list] [next in list] [prev in thread] [next in thread]