[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] Fix memory leak dispatching domain events
From:       Eric Blake <eblake () redhat ! com>
Date:       2011-08-31 16:13:01
Message-ID: 4E5E5D8D.5030005 () redhat ! com
[Download RAW message or body]

On 08/31/2011 09:55 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange@redhat.com>
>
> When dispatching domain events we will create an XDR struct
> containing the event info. Some of this data may be allocated
> on the heap and so must be freed. The graphics event dispatcher
> had a broken attempt to free one field, but missed others. All
> the events have a dom->name string that needs freeing. The code
> should have used the xdr_free() procedure for doing all this
>
> * daemon/remote.c: Use xdr_free after dispatching events
> ---
>   daemon/remote.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)

ACK.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[prev in list] [next in list] [prev in thread] [next in thread]