[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH 09/10 V2] send-key: Expose the new API in virsh
From:       Eric Blake <eblake () redhat ! com>
Date:       2011-08-31 14:24:50
Message-ID: 4E5E4432.8000600 () redhat ! com
[Download RAW message or body]

On 06/14/2011 01:33 PM, Eric Blake wrote:
>>> +++ b/tools/virsh.pod
>>> @@ -296,6 +296,10 @@ scheduling by the hypervisor.
>>>
>>>   Inject NMI to the guest
>>>
>>> +=item B<send-key>  I<domain-id>  I<--codeset>  B<codeset>  I<--holdtime>  B<holdtime>  B<keycode>...
>
> long line, and mark which items are optional:
>
> item B<send-key>  I<domain-id>  optional I<--codeset>  B<codeset>
> optional I<--holdtime>  B<holdtime>  B<keycode>...
>
> [Hmm, we really ought to rewrite virsh.pod to use "[arg]" instead of
> "optional arg" everywhere, but that's a separate task]

All that advice, then I went ahead and changed virsh.pod to use [arg] 
everywhere in the meantime, so now send-key is the lone hold-out for 
using the old style.  I'll be preparing a patch.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[prev in list] [next in list] [prev in thread] [next in thread]