[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs
From:       Eric Blake <eblake () redhat ! com>
Date:       2010-11-30 14:51:47
Message-ID: 4CF50F83.8000107 () redhat ! com
[Download RAW message or body]


On 11/30/2010 03:09 AM, Jiri Denemark wrote:
>>> *** BLURB HERE ***
>>
>> Ignoring git's hint to add an overview, are we? :)
> 
> Not really ignoring, just not noticing and forgetting :-)
> 
>>> Jiri Denemark (2):
>>>   cpu: Add support for overriding path to CPU map XML file
>>>   tests: Add unit tests for internal CPU APIs
>>
>> ACK series, but should tests/cputest.c be given a copyright notice?
> Ah sure, I will add it.
> 
>> Also, make sure 'make syntax-check' passes; I noticed a failure on
>> sc_prohibit_empty_lines_at_EOF on tests/sputestdata/x86-nehalem-force.xml.
> And I would have sworn I did syntax-check... apparently I didn't. I'll fix
> that too.
> 
> Just wondering if this is an after-release thing or not. But I guess I can
> just wait few days before pushing and be safe.

I don't see any problem with pushing now - it improves the testsuite
coverage, with minimal change to the code base proper.  Always good to
have more testing included in a release.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]