[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH 5/9] Introduce public API for cancelling async domain jobs
From:       Daniel Veillard <veillard () redhat ! com>
Date:       2010-02-26 17:54:51
Message-ID: 20100226175451.GM5281 () redhat ! com
[Download RAW message or body]

On Thu, Feb 18, 2010 at 03:56:11PM +0000, Daniel P. Berrange wrote:
> The new virDomainAbortJob() method provides a way for a second
> thread to abort an ongoing job run by another thread. This
> extends to any API with  which the virDomainGetJobInfo() API
> is intended to work. Cancellation is not guarenteed, rather best
> effort on part of the hypervisor and not required to be implmented.
> 
> * include/libvirt/libvirt.h.in: Define virDomainAbortJob()
> ---
>  include/libvirt/libvirt.h.in |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 51c0844..25f10c8 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -1834,6 +1834,7 @@ struct _virDomainJobInfo {
>  
>  int virDomainGetJobInfo(virDomainPtr dom,
>                          virDomainJobInfoPtr info);
> +int virDomainAbortJob(virDomainPtr dom);

  I would feel a bit better if we could add a flags there for future
extensions, like POSIX kill() ended up with many different semantics
we may have to refine at some point.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[prev in list] [next in list] [prev in thread] [next in thread]