[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] build: avoid warning about return-with-value in	void function
From:       Eric Blake <eblake () redhat ! com>
Date:       2010-02-26 16:28:02
Message-ID: 4B87F692.4000800 () redhat ! com
[Download RAW message or body]


According to Jim Meyering on 2/26/2010 3:51 AM:
> I saw this:
> 
>     virsh.c: In function 'virshReportError':
>     virsh.c:363: warning: 'return' with a value, in function returning void
> 
> 
>>From fc83f08ac204cec5fba474a23bd19386d1a415d7 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@redhat.com>
> Date: Fri, 26 Feb 2010 11:50:34 +0100
> Subject: [PATCH] build: avoid warning about return-with-value in void function
> 
> * tools/virsh.c: Just "return;", not "return NULL;".

ACK.  Regression was introduced by Cole, in commit 48286963, probably due
to copy-n-paste.

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]