[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH 2/2] add --live support to "virsh dump"
From:       Jiri Denemark <jdenemar () redhat ! com>
Date:       2009-11-30 14:58:08
Message-ID: 20091130145808.GH550 () orkuz ! home
[Download RAW message or body]

> > In Xen it is buggy, so I chose to not support it.
> 
> Well some versions of Xen are buggy, but not neccessarily all of
> them. IMHO we should support it in libvirt because it is a trivial
> change to make. This at least lets users try the functionality and
> see if there are bugs in their version of Xen
> 
> eg, our code already does
> 
>     return xend_op(domain->conn, domain->name, "op", "dump", "file", filename,
>                    "live", "0", "crash", "0", NULL);
> 
> so it is easy to set   "live", "1"   based on flags

Well, the live dump implementation in xen is just bogus even upstream but I
agree we should support it in xen driver because xen claims to support it and
it's not our problem that their code for that is buggy. Furthermore they could
fix it in the future and then it will just work.

Jirka

[prev in list] [next in list] [prev in thread] [next in thread]