[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH] (v2) avoid chowning domain devices if higer-level mgmt does it for us
From:       "Daniel P. Berrange" <berrange () redhat ! com>
Date:       2009-11-30 9:46:03
Message-ID: 20091130094603.GA26917 () redhat ! com
[Download RAW message or body]

On Sun, Nov 29, 2009 at 03:54:30PM +0200, Dan Kenigsberg wrote:
> Only now did I notice another problem with root_squasing nfs, unrelated
> to chown and unadressed by my patch: qemudDomainSave tries to create the
> target image file and write into it as root. How reasonable would it be
> to seteuid() to qemu user before doing so?

The trouble with directly doing  seteuid() is that it affects all
threads in the process, not just the thread doing the save() operation.
We would thus need to fork a tiny helper program before doing the 
seteuid() step to create the file.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

[prev in list] [next in list] [prev in thread] [next in thread]