[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    [libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()
From:       Tatsuro Enokura <fj2026af () aa ! jp ! fujitsu ! com>
Date:       2009-04-30 7:00:54
Message-ID: 49F94CA6.1060206 () aa ! jp ! fujitsu ! com
[Download RAW message or body]

Hi all,

The form of cpumap argument in op_pincpu method on xend change
by following a patch.
  http://xenbits.xensource.com/xen-unstable.hg?rev/a63d20d7a941

xenDaemonDomainPinCpu() sends the string for cpumap argument
like python's list style now.
This patch is following the change of cpumap argument.
  "[0,1,2]"    --->   "0,1,2"

Signed-off-by: Tatsuro Enokura <fj2026af@aa.jp.fujitsu.com>
# my e-mail address has changed.

Thanks
Tatsuro Enokura

["xend_op_pincpu.patch" (text/plain)]

Index: src/xend_internal.c
===================================================================
RCS file: /data/cvs/libvirt/src/xend_internal.c,v
retrieving revision 1.260
diff -u -r1.260 xend_internal.c
--- src/xend_internal.c 24 Apr 2009 12:17:50 -0000      1.260
+++ src/xend_internal.c 30 Apr 2009 01:40:59 -0000
@@ -3760,7 +3760,7 @@
 xenDaemonDomainPinVcpu(virDomainPtr domain, unsigned int vcpu,
                      unsigned char *cpumap, int maplen)
 {
-    char buf[VIR_UUID_BUFLEN], mapstr[sizeof(cpumap_t) * 64] = "[";
+    char buf[VIR_UUID_BUFLEN], mapstr[sizeof(cpumap_t) * 64] = "";
     int i, j;

     if ((domain == NULL) || (domain->conn == NULL) || (domain->name == NULL)
@@ -3776,7 +3776,7 @@
         snprintf(buf, sizeof(buf), "%d,", (8 * i) + j);
         strcat(mapstr, buf);
     }
-    mapstr[strlen(mapstr) - 1] = ']';
+    mapstr[strlen(mapstr) - 1] = '\0';
     snprintf(buf, sizeof(buf), "%d", vcpu);
     return(xend_op(domain->conn, domain->name, "op", "pincpu", "vcpu", buf,
                   "cpumap", mapstr, NULL));


[prev in list] [next in list] [prev in thread] [next in thread]