[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] PATCH: Fix infinite loop when QEMU quits at startup
From:       Guido =?iso-8859-1?Q?G=FCnther?= <agx () sigxcpu ! org>
Date:       2009-01-31 13:58:38
Message-ID: 20090131135838.GA13301 () bogon ! ms20 ! nix
[Download RAW message or body]

Hi Daniel,
On Fri, Jan 30, 2009 at 11:37:35AM +0000, Daniel P. Berrange wrote:
> @@ -670,11 +674,17 @@ qemudReadMonitorOutput(virConnectPtr con
>                                   _("Failure while reading %s startup output"), what);
>                  return -1;
>              }
> +        } else if (ret == 0) {
> +            return 0;
This part causes problems for me if qemu didn't get a chance to dump
it's output yet and so we hit EOF immediately since we don't respect the
poll timeout. Reverting this one hunk works around the issue.
I can look into fixing this properly but it will be a couple of days
until I get round to.
Cheers,
 -- Guido

[prev in list] [next in list] [prev in thread] [next in thread]