[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [libvirt] [PATCH]: don't hardcode default port 22 for ssh protocol
From:       Guido =?iso-8859-1?Q?G=FCnther?= <agx () sigxcpu ! org>
Date:       2009-01-31 13:49:18
Message-ID: 20090131134918.GA7879 () bogon ! ms20 ! nix
[Download RAW message or body]

On Sat, Jan 31, 2009 at 12:25:54PM +0100, Jim Meyering wrote:
> Guido Günther <agx@sigxcpu.org> wrote:
> > attached patch removes the hardcoded port 22 when going through ssh, ssh
> > uses it by default. This makes it easier to override this via
> > .ssh/config on a per host basis instead of having to add this to the
> > connection URI explicitly.
> 
> Good idea!
> 
> > While at that I cleaned up some free vs. VIR_FREE usage and replaced
> > pointer intializations with 0 by NULL.
> 
> Always welcome.  Thanks!
> 
> ACK, with one suggestion:
Applied with your suggestion.
 -- Guido

[prev in list] [next in list] [prev in thread] [next in thread]