[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libvir-list
Subject:    Re: [Libvir] [PATCH] 2/2 Factor out query parsing from remote
From:       "Daniel P. Berrange" <berrange () redhat ! com>
Date:       2007-12-14 14:37:55
Message-ID: 20071214143755.GF9211 () redhat ! com
[Download RAW message or body]

On Thu, Dec 13, 2007 at 06:24:07PM +0000, Richard W.M. Jones wrote:
> This pulls the query parsing code from remote_internal.c and makes it 
> use the functions in qparams.c instead.
> 
> Also I've changed DEBUG to use the global ENABLE_DEBUG symbol, and 
> replaced calls to strcasecmp with STRCASEEQ macro.

Looks good - any code which modularizing / simplifies the remote driver
is good - we've got rather a large amount of code in that one file.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[prev in list] [next in list] [prev in thread] [next in thread]