[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libreswan-dev
Subject:    [Swan-dev] Cleaning up #includes in .c files
From:       Andrew Cagney <andrew.cagney () gmail ! com>
Date:       2018-07-20 16:03:24
Message-ID: CAJeAr6vf5Ge8yAqj8CT-Us7Q0k93r+RZdxmMk5Yefk0cUvC=PA () mail ! gmail ! com
[Download RAW message or body]

As Antony's notice. I've been aggressively pruning the #includes for
various C files. Think of this as paying back the technical debt we've
accumulated over the years:

- when the file was created, instead of starting the #include list
from scratch, some existing list of #includes was cut/pasted
- for others, when the file was written, linux headers were pretty
messed up but that has long since been fixed

The problem is that I really can't cover all possible configurations.
However, what I'll do is add a few more to my list of test builds.
If anyone knows of a linting tool for helping here, let me know.

Andrew

---------- Forwarded message ---------
From: Antony Antony <antony@vault.libreswan.fi>
Date: Fri, 20 Jul 2018 at 05:53
Subject: [Swan-commit] Changes to ref refs/heads/master
To: <swan-commit@lists.libreswan.org>


New commits:
commit 9e52c55ebb9199577fd75df5fe9fa973038869a4
Author: Antony Antony <antony@phenome.org>
Date:   Fri Jul 20 11:51:12 2018 +0200

    addcon: include netdb.h

    92ceb628b was a bit aggressive.
    addcon fails to compile with USE_DNSSEC=false

    /home/build/libreswan/lib/libswan/addr_lookup.c:58:8: error:
implicit declaration of function 'getnameinfo'
[-Werror=implicit-function-declaration]
            getnameinfo(sa,
            ^
    /home/build/libreswan/lib/libswan/addr_lookup.c:58:8: error:
nested extern declaration of 'getnameinfo' [-Werror=nested-externs]

_______________________________________________
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-commit
_______________________________________________
Swan-dev mailing list
Swan-dev@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-dev
[prev in list] [next in list] [prev in thread] [next in thread]