[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libreswan-commit
Subject:    Re: [Swan-commit] Changes to ref refs/heads/master
From:       Andrew Cagney <andrew.cagney () gmail ! com>
Date:       2019-02-28 15:20:49
Message-ID: CAJeAr6sGYS-8QpYjTYJ-3D2rh6akFDQX3OXmNW=1mqS14vP5Tg () mail ! gmail ! com
[Download RAW message or body]

On Wed, 27 Feb 2019 at 23:25, Paul Wouters <paul@vault.libreswan.fi> wrote:
>
> New commits:
> commit c46b7d010ba30670a768b1651070a666211e648c
> Author: Paul Wouters <pwouters@redhat.com>
> Date:   Wed Feb 27 23:24:24 2019 -0500
>
>     IKEv1: Another follow up on aa6b8949
>
>     It also broke msgid handling for DPD and DELETE routines.

I suspect this doesn't fix the bug (I went through and tracked down
and fixed all the cases that caused a test fail, this one didn't come
up):

- the host ordered msgid and stored in the header, will be switched to
network order on the way out

- so the hash code should be fed the hton(msgid) value (in fact, there
are so many cases of the same code it should be moved to a function)

Andrew
_______________________________________________
Swan-commit mailing list
Swan-commit@lists.libreswan.org
https://lists.libreswan.org/mailman/listinfo/swan-commit
[prev in list] [next in list] [prev in thread] [next in thread]