[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libreoffice-commits
Subject:    [Libreoffice-commits] core.git: connectivity/source
From:       lionel () mamane ! lu (Lionel Elie Mamane)
Date:       2015-01-31 16:03:16
Message-ID: 20150131160316.700207634C () kemper ! freedesktop ! org
[Download RAW message or body]

 connectivity/source/drivers/macab/MacabStatement.cxx |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit d2a6d6a1a05337dbb733a9a3d4926a5c6d6cd8cd
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Sat Jan 31 17:01:15 2015 +0100

    tdf#88814 parameters are kinda-partially supported, so follow the suggestion
    
    Change-Id: I1a39378d521f128e6b8f35a0bce781435f94e5a8

diff --git a/connectivity/source/drivers/macab/MacabStatement.cxx \
b/connectivity/source/drivers/macab/MacabStatement.cxx index f807b5b..2de3f3f 100644
--- a/connectivity/source/drivers/macab/MacabStatement.cxx
+++ b/connectivity/source/drivers/macab/MacabStatement.cxx
@@ -85,7 +85,6 @@ void MacabCommonStatement::disposing()
 
 void MacabCommonStatement::resetParameters() const \
throw(::com::sun::star::sdbc::SQLException)  {
-    impl_throwError(STR_PARA_ONLY_PREPARED);
 }
 
 void MacabCommonStatement::getNextParameter(OUString &) const \
throw(::com::sun::star::sdbc::SQLException) @@ -325,9 +324,7 @@ void \
MacabCommonStatement::selectRecords(MacabResultSet *pResult) const throw(SQ  {
         if (SQL_ISRULE(pParseNode, where_clause))
         {
-            // Since we don't support parameters, don't reset them. If we ever
-            // support them, uncomment this line and fix resetParameters.
-            //resetParameters();
+            resetParameters();
             pParseNode = pParseNode->getChild(1);
             MacabCondition *pCondition = analyseWhereClause(pParseNode);
             if (pCondition->isAlwaysTrue())


[prev in list] [next in list] [prev in thread] [next in thread]