[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libreoffice
Subject:    Re: minutes of ESC call ...
From:       Miklos Vajna <vmiklos () collabora ! co ! uk>
Date:       2017-11-08 8:51:13
Message-ID: 20171108085112.n5skbfytt2pbdakf () collabora ! co ! uk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi Stephan,

On Wed, Nov 08, 2017 at 09:44:02AM +0100, Stephan Bergmann <sbergman@redhat.com> \
wrote:
> And, just to clarify, for me that means that enforcement on new files cannot
> be opt-in based on whatever personal concerns, as might be read out of the
> commit message of <https://cgit.freedesktop.org/libreoffice/core/commit/?id=5946eedfb78e250a40f14ae1e5b709e827b2504c>
>  "test: clang-format recently added xsheet tests":  "Jens says he was unhappy
> with the 80 cols limit, so clang-format was explicitly avoided for these new
> files [...]"

Makes sense -- the Code-Review label discussion in the other thread
sounds like we'll have the enforcement at a gerrit level (as well) soon,
which should address the case when enforcement is avoided locally
(either implicitly or explicitly).

Regards,

Miklos


["signature.asc" (application/pgp-signature)]
[Attachment #6 (text/plain)]

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic