[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libguestfs
Subject:    =?utf-8?q?=5BLibguestfs=5D?= Re: [libnbd PATCH 3/3] copy: Add test for server without meta context s
From:       Eric Blake <eblake () redhat ! com>
Date:       2024-02-21 22:12:14
Message-ID: lifcjs3ben2twiel6phdcw7q4j4jhk33iqznql3qfeq2fpcopq () k5o7dtveft6z
[Download RAW message or body]

On Wed, Feb 21, 2024 at 07:08:50PM +0000, Richard W.M. Jones wrote:
> On Wed, Feb 21, 2024 at 08:53:52AM -0600, Eric Blake wrote:
> > nbd-server 3.24 behaves like 'nbdkit --no-sr', and we were gracefully
> > handling that.  But nbd-server 3.25 added structured replies while
> > still leaving meta contexts unsupported.  This patch adds testsuite
> > coverage for that case by relying on a new feature in upcoming nbdkit
> > 1.38, independently of two previous patches (one to nbdcopy and one to
> > nbd_can_meta_context), so that you can rearrange application of the
> > patch series and see that either fix in isolation prevents nbdcopy
> > from tripping over a spurious failure.
> > 

> 
> For 1 & 3:
> 
> Reviewed-by: Richard W.M. Jones <rjones@redhat.com>

With subsequent reviewed modifications to 2, and the followon patch to
let nbdinfo show contents of nbd-server, I've now pushed patches
2b1f9dad..a0aa3c16.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org
_______________________________________________
Libguestfs mailing list -- guestfs@lists.libguestfs.org
To unsubscribe send an email to guestfs-leave@lists.libguestfs.org

[prev in list] [next in list] [prev in thread] [next in thread]