[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libguestfs
Subject:    Re: [Libguestfs] [PATCH nbdkit 4/9] common/regions: Use new vector type to store the list of regions
From:       "Richard W.M. Jones" <rjones () redhat ! com>
Date:       2020-04-15 20:30:20
Message-ID: 20200415203020.GQ3888 () redhat ! com
[Download RAW message or body]

On Wed, Apr 15, 2020 at 03:28:24PM -0500, Eric Blake wrote:
> >  /* Return the number of regions. */
> >  static inline size_t __attribute__((__nonnull__ (1)))
> >-nr_regions (struct regions *regions)
> >+nr_regions (struct regions *rs)
> 
> whereas this one is odd.  Did you mean to drop 'struct' here?  If
> so, do you still have to rename the variable to rs?  Okay, I'm
> seeing the pattern - forward declarations don't trigger -Wshadow,
> but implementations do.

Right, but also I should drop the struct.  Will update my copy.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[prev in list] [next in list] [prev in thread] [next in thread]