[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libguestfs
Subject:    Re: [Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8
From:       Pino Toscano <ptoscano () redhat ! com>
Date:       2020-02-24 9:32:27
Message-ID: 3911356.dF2Fq0d9NU () lindworm ! usersys ! redhat ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday, 16 January 2020 16:15:42 CET Richard W.M. Jones wrote:
> On Thu, Jan 16, 2020 at 04:05:10PM +0100, Tomáš Golembiovský wrote:
> > There was no source directory for EL8 guest agent (only EL6 and EL7).
> > 
> > RHBZ#1791802
> > 
> > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > ---
> >  v2v/windows_virtio.ml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
> > index 5ec7664b..86bc8c0a 100644
> > --- a/v2v/windows_virtio.ml
> > +++ b/v2v/windows_virtio.ml
> > @@ -192,6 +192,7 @@ and install_linux_tools g inspect =
> >        (match inspect.i_major_version with
> >         | 6 -> Some "el6"
> >         | 7 -> Some "el7"
> > +       | 8 -> Some "el8"
> >         | _ -> None)
> >      | "sles" | "suse-based" | "opensuse" -> Some "lp151"
> >      | _ -> None in
> 
> ACK from me.

LGTM too, so pushed:
https://github.com/libguestfs/virt-v2v/commit/79dd6a6bbb7e95691be18f54d601318d7d713702

Thanks,
-- 
Pino Toscano
["signature.asc" (application/pgp-signature)]

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

[prev in list] [next in list] [prev in thread] [next in thread]