[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libguestfs
Subject:    Re: [Libguestfs] [PATCH nbdkit] common: Improve pseudo-random number generation.
From:       "Richard W.M. Jones" <rjones () redhat ! com>
Date:       2018-12-28 20:32:08
Message-ID: 20181228203208.GU4080 () redhat ! com
[Download RAW message or body]

This patch is rather obviously wrong if you examine the output
of the random plugin:

$ ./nbdkit -U - random size=1M --run 'qemu-img convert $nbd /tmp/random.img'
$ hexdump -C /tmp/random.img 
00000000  00 80 00 80 00 80 00 80  00 80 00 80 00 80 00 80  |................|
*
00100000

So um yes I'll try to fix this and improve the test too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
[prev in list] [next in list] [prev in thread] [next in thread]