[prev in list] [next in list] [prev in thread] [next in thread] 

List:       libguestfs
Subject:    Re: [Libguestfs] [PATCH 4/4] Fix out-of-tree build (install target) for translations
From:       "Richard W.M. Jones" <rjones () redhat ! com>
Date:       2012-05-24 7:35:06
Message-ID: 20120524073506.GC18506 () amd ! home ! annexia ! org
[Download RAW message or body]

On Thu, May 24, 2012 at 01:21:06AM +0200, Hilko Bengen wrote:
> ---
>  po/Makefile.am |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/po/Makefile.am b/po/Makefile.am
> index 90b23c1..c620d57 100644
> --- a/po/Makefile.am
> +++ b/po/Makefile.am
> @@ -96,7 +96,7 @@ install-data-hook:
>  	for lang in $(linguas); do \
>  	  d=$(DESTDIR)$(langinstdir)/$$lang/LC_MESSAGES; \
>  	  mkdir -p $$d; \
> -	  install -m 0755 $$lang.gmo $$d/$(DOMAIN).mo; \
> +	  install -m 0755 $(srcdir)/$$lang.gmo $$d/$(DOMAIN).mo; \
>  	done
>  
>  .PRECIOUS: $(DOMAIN).pot $(POFILES)
> -- 

Since these (*.gmo) files are built, shouldn't they in fact be in
builddir?

Perhaps the problem is with these rules:

  POFILES    := $(patsubst %,$(srcdir)/%.po,$(linguas))
  ...
          cp $(srcdir)/*.po *.gmo $(distdir)/

The *.po files are generated during the build, but are really source
files because (a) they go in the tarball and (b) they are modified by
translators and the changes that the translators make are '.PRECIOUS'.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/

[prev in list] [next in list] [prev in thread] [next in thread]