'Re: Some issues with project plugin ?'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Some issues with project plugin ?
From:       Tyler <tyler () linuxdev ! app>
Date:       2023-01-24 23:58:43
Message-ID: NMaD2a8--3-9 () linuxdev ! app
[Download RAW message or body]

Would CWalk be any help here?
https://github.com/likle/cwalk

Tyler

Jan 24, 2023, 11:52 PM by neundorf@kde.org:

> On Montag, 23. Januar 2023 23:42:41 CET Alexander Neundorf wrote:
>
>> Hi,
>>
>> are there any known issues with the project plugin ?
>> I haven't investigated yet, but here is what I see:
>> it looks like, that even though in the .kateproject file, the "files" entry
>> is not empty, but contains a long list of files, kate doesn't seem to know
>> about any files in that project. Is it possible that the "list" mode is
>> broken ?
>>
>
> It is indeed broken.
>
> In void KateProjectWorker::loadFilesEntry(), "fullFilePath" is set like this:
>  fullFilePath = dirPath + filePath;
>
> without checking whether filePath is already an absolute path.
> So if the list of files in the kateproject file already contains absolute paths, 
> the base directory is prepended to those absolute paths, which results in bad 
> paths.
>
> I could check QFileInfo::isAbsolute(), but the comment says that's too slow.
> If nobody else is faster, I'll do something in the next days.
>
> Alex
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
  </head>
  <body>
<div>Would CWalk be any help here?<br></div><div dir="auto"><a \
href="https://github.com/likle/cwalk">https://github.com/likle/cwalk</a><br></div><div \
dir="auto"><br></div><div dir="auto">Tyler<br></div><div><br></div><div>Jan 24, 2023, \
11:52 PM by neundorf@kde.org:<br></div><blockquote class="tutanota_quote" \
style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>On \
Montag, 23. Januar 2023 23:42:41 CET Alexander Neundorf \
wrote:<br></div><blockquote><div>Hi,<br></div><div><br></div><div>are there any known \
issues with the project plugin ?<br></div><div>I haven't investigated yet, but here \
is what I see:<br></div><div>it looks like, that even though in the .kateproject \
file, the "files" entry<br></div><div>is not empty, but contains a long list of \
files, kate doesn't seem to know<br></div><div>about any files in that project. Is it \
possible that the "list" mode is<br></div><div>broken \
?<br></div></blockquote><div><br></div><div>It is indeed \
broken.<br></div><div><br></div><div>In void KateProjectWorker::loadFilesEntry(), \
"fullFilePath" is set like this:<br></div><div> fullFilePath = dirPath + \
filePath;<br></div><div><br></div><div>without checking whether filePath is already \
an absolute path.<br></div><div>So if the list of files in the kateproject file \
already contains absolute paths, <br></div><div>the base directory is prepended to \
those absolute paths, which results in bad \
<br></div><div>paths.<br></div><div><br></div><div>I could check \
QFileInfo::isAbsolute(), but the comment says that's too slow.<br></div><div>If \
nobody else is faster, I'll do something in the next \
days.<br></div><div><br></div><div>Alex<br></div></blockquote><div \
dir="auto"><br></div>  </body> </html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic