[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: fuzzy-matching in quickopen...
From:       Waqar Ahmed <waqar.17a () gmail ! com>
Date:       2022-09-29 20:46:02
Message-ID: CAPesRH4cabxZ-=99tZn6TMj8AQ1cJTA=_iu2RYqaHPP561LrPQ () mail ! gmail ! com
[Download RAW message or body]

Hi

You can try latest master, I implemented some of the suggestions and
results look better to me already. Also, open files are given more
preference if the are a good match.

Besides that, I will soon be pushing another patch which brings back the
old way. It is trivial to add it again so why not.

On Wed, Sep 28, 2022, 2:03 AM Alexander Neundorf <neundorf@kde.org> wrote:

> Hi Waqar,
>
> On Dienstag, 27. September 2022 17:05:00 CEST Waqar Ahmed wrote:
> > For the second screenshot, results are great for the query.
> > "search.ui" is a near perfect match. Instead if you had typed "sc",
> > which is much shorter, it would be most likely the first result. **For
> > the Nth time, You need to leverage the fuzzy stuff**.
> >
> > "Prefer Open Files" and then giving a score of 1000 is just completely
> > wrong. Sorry. It is not "preferring" anymore, it is brutally bringing
> > up an open file even though it might be the worst possible match.
> > Thats not how it is supposed to work.
> >
> > Btw, did you even try the MR where I tagged you?
>
> sorry, no, I missed that. When was it ?
> Can you please post the link again ?
>
> > I think what you want is a quickopen for openfiles only. That can be
> > added as a config, we can then ignore project files and just filter on
> > whatever is open.
>
> No, that is not what I want.
> I know I'm repeating myself, but the old way worked great for me.
> I entered a few characters, if the file was already open, it appeared at
> the
> top, if it was not open, it appeared also, just a bit further down.
>
> Alex
>
>
>
>

[Attachment #3 (text/html)]

<div dir="auto"><div>Hi</div><div dir="auto"><br></div><div dir="auto">You can try \
latest master, I implemented some of the suggestions and results look better to me \
already. Also, open files are given more preference if the are a good match.  \
</div><div dir="auto"><br></div><div dir="auto">Besides that, I will soon be pushing \
another patch which brings back the old way. It is trivial to add it again so why \
not.  </div><div dir="auto"><br><div class="gmail_quote" dir="auto"><div dir="ltr" \
class="gmail_attr">On Wed, Sep 28, 2022, 2:03 AM Alexander Neundorf &lt;<a \
href="mailto:neundorf@kde.org">neundorf@kde.org</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Waqar,<br> <br>
On Dienstag, 27. September 2022 17:05:00 CEST Waqar Ahmed wrote:<br>
&gt; For the second screenshot, results are great for the query.<br>
&gt; &quot;search.ui&quot; is a near perfect match. Instead if you had typed \
&quot;sc&quot;,<br> &gt; which is much shorter, it would be most likely the first \
result. **For<br> &gt; the Nth time, You need to leverage the fuzzy stuff**.<br>
&gt; <br>
&gt; &quot;Prefer Open Files&quot; and then giving a score of 1000 is just \
completely<br> &gt; wrong. Sorry. It is not &quot;preferring&quot; anymore, it is \
brutally bringing<br> &gt; up an open file even though it might be the worst possible \
match.<br> &gt; Thats not how it is supposed to work.<br>
&gt; <br>
&gt; Btw, did you even try the MR where I tagged you?<br>
<br>
sorry, no, I missed that. When was it ?<br>
Can you please post the link again ?<br>
<br>
&gt; I think what you want is a quickopen for openfiles only. That can be<br>
&gt; added as a config, we can then ignore project files and just filter on<br>
&gt; whatever is open.<br>
<br>
No, that is not what I want.<br>
I know I&#39;m repeating myself, but the old way worked great for me.<br>
I entered a few characters, if the file was already open, it appeared at the <br>
top, if it was not open, it appeared also, just a bit further down.<br>
<br>
Alex<br>
<br>
<br>
<br>
</blockquote></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]