[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: fuzzy-matching in quickopen...
From: Waqar Ahmed <waqar.17a () gmail ! com>
Date: 2022-09-23 22:06:34
Message-ID: CAPesRH6px_ZJpsmc4VCp5W7m2FzCNmuX47qetV8eROfDd-Z_rQ () mail ! gmail ! com
[Download RAW message or body]
I am against adding the old way, but if it's optional, ok sure as long as
it is disabled by default.
Your approach is completely incorrect though and the only reason I will say
ok to the patch is because Christoph already said ok. We can and should
improve the algorithm instead rather than just bringing back the old way on
the first complaint.
On Sat, Sep 24, 2022, 2:14 AM Alexander Neundorf <neundorf@kde.org> wrote:
> On Freitag, 16. September 2022 18:21:52 CEST Christoph Cullmann (
> cullmann.io) wrote:
>
> > On 2022-09-16 16:25, Waqar Ahmed wrote:
>
> > > 1. After filtering, why should open files always end up at top? This
>
> > > is not an "already open files quickopen". If the filter matches
>
> > > something else better that will end up at top. There might be cases
>
> > > where an openfile is a better match, perhaps there is a way to improve
>
> > > that without biasing 100% in favour of open files.
>
> > >
>
> > > 2. Match in sequence will take precedence once you have typed 4 or
>
> > > more letters. With 3 or less letters, we can't be sure if that is a
>
> > > sequence or an abbreviation. e.g., ftv will prefer "FilesTreeView"
>
> > > over "abcftv.js"
>
> > >
>
> > > 3. That is correct and working as expected.
>
> > >
>
> > > Quickopen is not meant to filter already open files. For that, you
>
> > > have other plugins that can do the job.
>
> > >
>
> > > If you have a concrete case where X is a better match, discussing that
>
> > > would be better.
>
> >
>
> > The question is, if some people liked the very old behavior of
>
> > preferences for
>
> > open files, if somebody provides a patch to make this configurable via
>
> > the
>
> > context menu (as we have already for the project scope), I think that
>
> > would be
>
> > acceptable.
>
> >
>
> > A config option in the context menu is non-intrusive and will IMHO
>
> > annoy nobody.
>
> I created a merge request, it let's the user select "Fuzzy search" or
> "Wildcard matching":
>
> https://invent.kde.org/utilities/kate/-/merge_requests/897
>
> Alex
>
>
[Attachment #3 (text/html)]
<div dir="auto"><div>I am against adding the old way, but if it's optional, ok sure as long as it is \
disabled by default. </div><div dir="auto"><br></div><div dir="auto">Your approach is completely \
incorrect though and the only reason I will say ok to the patch is because Christoph already said ok. We \
can and should improve the algorithm instead rather than just bringing back the old way on the first \
complaint. </div><div dir="auto"><br><div class="gmail_quote" dir="auto"><div dir="ltr" \
class="gmail_attr">On Sat, Sep 24, 2022, 2:14 AM Alexander Neundorf <<a \
href="mailto:neundorf@kde.org">neundorf@kde.org</a>> wrote:<br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">On Freitag, 16. September 2022 \
18:21:52 CEST Christoph Cullmann (<a href="http://cullmann.io" target="_blank" \
rel="noreferrer">cullmann.io</a>) wrote:</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> On 2022-09-16 16:25, Waqar Ahmed \
wrote:</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > 1. After \
filtering, why should open files always end up at top? This</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > is not an "already open \
files quickopen". If the filter matches</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > something else better that \
will end up at top. There might be cases</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > where an openfile is a better \
match, perhaps there is a way to improve</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > that without biasing 100% in \
favour of open files.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > \
</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > 2. Match in sequence \
will take precedence once you have typed 4 or</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > more letters. With 3 or less \
letters, we can't be sure if that is a</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > sequence or an abbreviation. \
e.g., ftv will prefer "FilesTreeView"</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > over \
"abcftv.js"</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > \
</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > 3. That is correct \
and working as expected.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> \
> </p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > Quickopen is not \
meant to filter already open files. For that, you</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > have other plugins that can \
do the job.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > </p>
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > If you have a concrete \
case where X is a better match, discussing that</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> > would be better.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> The question is, if some people \
liked the very old behavior of</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> preferences for</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> open files, if somebody provides a \
patch to make this configurable via</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> the</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> context menu (as we have already \
for the project scope), I think that</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> would be</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> acceptable.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> A config option in the context \
menu is non-intrusive and will IMHO</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">> annoy nobody.</p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">I created a merge request, it let's \
the user select "Fuzzy search" or "Wildcard matching":</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0"><a \
href="https://invent.kde.org/utilities/kate/-/merge_requests/897" target="_blank" \
rel="noreferrer">https://invent.kde.org/utilities/kate/-/merge_requests/897</a></p> <br><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0">Alex</p> <br></div>
</blockquote></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic