[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: fuzzy-matching in quickopen...
From: Alexander Neundorf <neundorf () kde ! org>
Date: 2022-09-17 9:31:49
Message-ID: 2046702.KlZ2vcFHjT () unknown0090f5ef9f13
[Download RAW message or body]
On Freitag, 16. September 2022 22:33:36 CEST Waqar Ahmed wrote:
> > Are you sure this is a better behaviour ?
>
> It doesn't matter. With a single letter one cannot really get very far and
> can't really do much scoring. So I wouldn't waste time on thinking about
> the single typed letter case.
>
> > which ? I thought that's what quickopen is for, really. At least it was
>
> until
> a year ago.
>
> No, that is not what it is for. If it were, it wouldn't even list other
> files at all. Quickopen is for opening files in your project + any already
> open files (which may or may not be in the project)
>
> And quickopen is two years old by now. It was already there when you were
> making those search/replace patches.
quickopen is much older than that (see e.g. https://github.com/KDE/kate/blob/
21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp[1] ), and there the
comments say "... get all open documents", later on "insert all project files, if any project
around", so that was more an added bonus.
> Tab switcher / documents plugin deal with already open files.
What's the tab switcher ? Maybe that's a feature I'm not aware of.
The documents side panel is not quick to use, I have to use the mouse, I have to search
manually.
> You can try increasing the score of already open files. Maybe it will make
> it better, maybe not. Right now only one point is added, which is probably
> too low. Maybe there is a better way to add this score so that files that
> are a good match + open are ranked better.
Is there a unit test or example for the fuzzy matching somewhere already ?
Thanks
Alex
--------
[1] https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/
katequickopen.cpp
[Attachment #3 (unknown)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">On Freitag, 16. September \
2022 22:33:36 CEST Waqar Ahmed wrote:</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > Are you sure this is a \
better behaviour ?</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p>
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> It doesn't matter. With a \
single letter one cannot really get very far and</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> can't really do much scoring. So \
I wouldn't waste time on thinking about</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> the single typed letter case.</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > which ? I thought that's \
what quickopen is for, really. At least it was</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> until</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> a year ago.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> No, that is not what it is for. \
If it were, it wouldn't even list other</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> files at all. Quickopen is for \
opening files in your project + any already</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> open files (which may or may not \
be in the project)</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p>
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> And quickopen is two years old \
by now. It was already there when you were</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> making those search/replace \
patches.</p> <br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">quickopen is \
much older than that (see e.g. <a \
href="https://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp">ht \
tps://github.com/KDE/kate/blob/21f6e144ac9b11003fec518d2f502548f33fd4b1/kate/katequickopen.cpp</a> ), \
and there the comments say "... get all open documents", later on "insert all project \
files, if any project around", so that was more an added bonus.</p> <br /><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> Tab switcher / documents plugin \
deal with already open files.</p> <br /><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">What's the tab switcher ? Maybe that's \
a feature I'm not aware of.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">The \
documents side panel is not quick to use, I have to use the mouse, I have to search manually.</p> <br \
/><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> You can try increasing the \
score of already open files. Maybe it will make</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> it better, maybe not. Right now \
only one point is added, which is probably</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> too low. Maybe there is a better \
way to add this score so that files that</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> are a good match + open are \
ranked better.</p> <br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Is there a \
unit test or example for the fuzzy matching somewhere already ?</p> <br /><p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Thanks</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Alex</p> <br /></body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic