[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Filtering also matches the filenames...
From: Kåre_Särs <kare.sars () mailbox ! org>
Date: 2022-03-08 13:07:02
Message-ID: 2098629.irdbgypaU6 () sars-xps-13-9370
[Download RAW message or body]
On tisdag 8 mars 2022 11:05:21 EET Waqar Ahmed wrote:
> > in the attached screenshot kate-rtes.png the filter text is "rtes", and
> > although this is not anywhere visible in the results, they all are
> > accepted by the filter. To me this looks clearly like a bug.
> > They are accepted because they are all somewhere below ...src/dockertest/
> > (which contains "rtes").
>
> Correct.
>
> > When I remove the search base directory for the filtering, it works
> > better,
> > but leads to the result as in kate-sub.png.
> > The filter is "sub", and all matches are displayed, since they are all in
> > the "sub/" directory, which is visible in the names of the file items.
> > But the number of matches is completely wrong then. The number of matches
> > counts how often the search time was found, and since none of the actual
> > text matches matches the filter, it is zero.
> > If the filtering would only test the actual content, I think this issue
> > would go away.
>
> Yes, but it removes a feature so imo not a good idea. Directory/file
> filtering was one of the main reasons I added this feature :)
>
> One big reason I didn't bother with updated row count was because this
> filter is temporary and not something you should rely on to find out
> how many matches there are *after* the filtering. The point is to be
> able to focus on a part of the search, hence updated rowCount for me
> is not useful at all.
>
I think we could at least ignore the common folder path when doing the filtering.
I think it is a bit un-intuitive to not have the match/checked count updated properly...
I think we should do the move of the checked/match count to the proxy/delegate even if it
is a bit more work and it could get a bit slower if we have thousands of matches/files. I
think I can have a look at it, that is if Alex does not want to do it ;)
Regards,
Kåre
> On Tue, Mar 8, 2022 at 1:54 PM Alexander Neundorf <neundorf@kde.org> wrote:
> > On Montag, 7. März 2022 20:06:27 CET Waqar Ahmed wrote:
> > > Also, I think using a single character for filtering is just
> > > unrealistic,
> > > and using it to test the filter quality is imo not useful. With a few
> > > more
> > > characters or a word, the filter will work better.
> >
> > in the attached screenshot kate-rtes.png the filter text is "rtes", and
> > although this is not anywhere visible in the results, they all are
> > accepted by the filter. To me this looks clearly like a bug.
> > They are accepted because they are all somewhere below ...src/dockertest/
> > (which contains "rtes").
> >
> > When I remove the search base directory for the filtering, it works
> > better,
> > but leads to the result as in kate-sub.png.
> > The filter is "sub", and all matches are displayed, since they are all in
> > the "sub/" directory, which is visible in the names of the file items.
> > But the number of matches is completely wrong then. The number of matches
> > counts how often the search time was found, and since none of the actual
> > text matches matches the filter, it is zero.
> > If the filtering would only test the actual content, I think this issue
> > would go away.
> >
> > Alex
[Attachment #3 (unknown)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">On tisdag \
8 mars 2022 11:05:21 EET Waqar Ahmed wrote:</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > in the \
attached screenshot kate-rtes.png the filter text is "rtes", and</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > although \
this is not anywhere visible in the results, they all are</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > accepted \
by the filter. To me this looks clearly like a bug.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > They are \
accepted because they are all somewhere below ...src/dockertest/</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > (which \
contains "rtes").</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> Correct.</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > When I \
remove the search base directory for the filtering, it works</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > \
better,</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> but leads to the result as in kate-sub.png.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > The \
filter is "sub", and all matches are displayed, since they are all in</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > the \
"sub/" directory, which is visible in the names of the file items.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > But the \
number of matches is completely wrong then. The number of matches</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > counts \
how often the search time was found, and since none of the actual</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > text \
matches matches the filter, it is zero.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > If the \
filtering would only test the actual content, I think this issue</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > would go \
away.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> Yes, \
but it removes a feature so imo not a good idea. Directory/file</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> filtering was \
one of the main reasons I added this feature :)</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> One big \
reason I didn't bother with updated row count was because this</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> filter is \
temporary and not something you should rely on to find out</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> how many \
matches there are *after* the filtering. The point is to be</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> able to focus \
on a part of the search, hence updated rowCount for me</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> is not useful \
at all.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
</p> <br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">I \
think we could at least ignore the common folder path when doing the filtering.</p> \
<br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">I think \
it is a bit un-intuitive to not have the match/checked count updated properly...</p> \
<br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">I think \
we should do the move of the checked/match count to the proxy/delegate even if it is \
a bit more work and it could get a bit slower if we have thousands of matches/files. \
I think I can have a look at it, that is if Alex does not want to do it ;)</p> <br \
/><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">Regards,</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;"> Kåre \
</p> <br /><br /><p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
On Tue, Mar 8, 2022 at 1:54 PM Alexander Neundorf <neundorf@kde.org> wrote:</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > On \
Montag, 7. März 2022 20:06:27 CET Waqar Ahmed wrote:</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > > \
Also, I think using a single character for filtering is just</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > > \
unrealistic,</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> > and using it to test the filter quality is imo not useful. With a few</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > > \
more</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> > characters or a word, the filter will work better.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > in the \
attached screenshot kate-rtes.png the filter text is "rtes", and</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > although \
this is not anywhere visible in the results, they all are</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > accepted \
by the filter. To me this looks clearly like a bug.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > They are \
accepted because they are all somewhere below ...src/dockertest/</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > (which \
contains "rtes").</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > </p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > When I \
remove the search base directory for the filtering, it works</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > \
better,</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> but leads to the result as in kate-sub.png.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > The \
filter is "sub", and all matches are displayed, since they are all in</p> \
<p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > the \
"sub/" directory, which is visible in the names of the file items.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > But the \
number of matches is completely wrong then. The number of matches</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > counts \
how often the search time was found, and since none of the actual</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > text \
matches matches the filter, it is zero.</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > If the \
filtering would only test the actual content, I think this issue</p> <p \
style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> > would go \
away.</p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> </p> <p style="margin-top:0;margin-bottom:0;margin-left:0;margin-right:0;">> \
> Alex</p> <br /><br /></body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic